Ducktap fix #155
Merged
Ducktap fix #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any reason why you moved the code down? It's very hard to see what the actual code differences are this way. Could you move it back where it was so the difference is readable please? |
|
I'm using in_duck.state check in function which is undeclared if i don't move function down |
YaLTeR
reviewed
Feb 25, 2022
cl_dll/input.cpp
Outdated
Comment on lines
165
to
168
| static bool duck_was_pressed = false; | ||
| static bool should_release_duck; | ||
|
|
||
| if (in_duck.state & 1) |
There was a problem hiding this comment.
Suggested change
| static bool duck_was_pressed = false; | |
| static bool should_release_duck; | |
| if (in_duck.state & 1) | |
| static bool should_release_duck; | |
| bool duck_was_pressed = false; | |
| if (in_duck.state & 1) |
Doesn't need to be a static if it's set every time.
Also please rename to duck_is_pressed and remove the set in the should_release_duck condition below as it does nothing.
|
Thanks! |
SmileyAG
pushed a commit
to SmileyAG/OpenAG
that referenced
this pull request
Dec 14, 2023
* ducktap fix * remove cl_duck_priority * some changes * remove unnecessary set
SmileyAG
pushed a commit
to SmileyAG/OpenAG
that referenced
this pull request
Dec 14, 2023
* ducktap fix * remove cl_duck_priority * some changes * remove unnecessary set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix +ducktap that you weren't able to interfere in "ducking" process, now its working like +bxt_tas_ducktap