Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Properly snap #92

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Properly snap #92

merged 2 commits into from
Sep 25, 2019

Conversation

StephenHodgson
Copy link
Contributor

Overview

  • Snapping was improperly using the transform to do the world space/local space translations.
  • Bounds center and size was incorrect. Used Collider size and center instead.

@StephenHodgson StephenHodgson self-assigned this Sep 25, 2019
@StephenHodgson StephenHodgson added the Bug Something isn't working label Sep 25, 2019
@StephenHodgson StephenHodgson merged commit 9bb932f into development Sep 25, 2019
@StephenHodgson StephenHodgson deleted the fix/manipulation-snapping branch September 25, 2019 23:07
@StephenHodgson StephenHodgson mentioned this pull request Oct 9, 2019
Merged
XRTK-Build-Bot pushed a commit that referenced this pull request Oct 9, 2019
@StephenHodgson
Properly snap (#92)
03a6cd6 
* Properly snap

* removed some debug lines
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimonDarksideJ SimonDarksideJ SimonDarksideJ approved these changes

@jamesashley1 jamesashley1 Awaiting requested review from jamesashley1

Assignees

@StephenHodgson StephenHodgson

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenHodgson @SimonDarksideJ