Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Remove DiagnosticsHandler #28

Merged
merged 2 commits into from
May 8, 2019
Merged

Remove DiagnosticsHandler #28

merged 2 commits into from
May 8, 2019

Conversation

FejZa
Copy link
Contributor

@FejZa FejZa commented May 4, 2019

It got replaced with the DiagnosticsSystemVisualProfiler in XRTK-Core

Overview

This is related to XRTK/com.xrtk.core#148 in the Core module. The DiagnosticsHandler is obsolete and replaced by the new Visual Profiler that lives in core.

Changes:

  • Removed DiagnosticsHandler component

Breaking Changes:

  • Might break Projects where People use the old DiagnosticsService and rely on this component being in the SDK module.

It got replaced with the DiagnosticsSystemVisualProfiler in XRTK-Core
@FejZa
Copy link
Contributor Author

FejZa commented May 4, 2019

XRTK-Core PR XRTK/com.xrtk.core#156 is part of this

@FejZa FejZa requested a review from StephenHodgson May 4, 2019 11:46
@StephenHodgson StephenHodgson merged commit 68c363b into XRTK:development May 8, 2019
@FejZa FejZa deleted the feature/diagnostics-system-port branch May 9, 2019 08:41
XRTK-Build-Bot pushed a commit that referenced this pull request May 12, 2019
It got replaced with the DiagnosticsSystemVisualProfiler in XRTK-Core
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants