Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dual_channel by multi_channel process #248

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Replace dual_channel by multi_channel process #248

merged 2 commits into from
Sep 12, 2023

Conversation

chainyo
Copy link
Contributor

@chainyo chainyo commented Sep 12, 2023

This PR updates the dual_channel process to make it functional with N audio channels.

  • Renamed dual_channel to multi_channel.
  • Simplified the audio pre-processing step based on the number of audio channels.
  • Removed one old dual_channel method.

@chainyo chainyo added api Everything related to the API implementation audio Everything related to the audio pre or post-processing labels Sep 12, 2023
@chainyo chainyo linked an issue Sep 12, 2023 that may be closed by this pull request
Handle N audio channels #240
Closed
@chainyo chainyo merged commit b117d53 into main Sep 12, 2023
2 checks passed
@chainyo chainyo deleted the 240-handle-n-audio-channels branch September 12, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandr-smechov aleksandr-smechov aleksandr-smechov approved these changes

Assignees
No one assigned
Labels
api Everything related to the API implementation audio Everything related to the audio pre or post-processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle N audio channels
2 participants
@chainyo @aleksandr-smechov