Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto dual-channel detection #239

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Add auto dual-channel detection #239

merged 2 commits into from
Sep 5, 2023

Conversation

chainyo
Copy link
Contributor

@chainyo chainyo commented Sep 5, 2023 •
edited
Loading

This PR:

  • Added a parameter to youtube-dl to make it quiet
  • Adds dual_channel auto-detection for audio URL and audio file endpoint (not youtube)
  • Fix a bug that returned <EMPTY AUDIO> when dual_channel was enabled with diarization

@chainyo chainyo added bug Something isn't working api Everything related to the API implementation audio Everything related to the audio pre or post-processing labels Sep 5, 2023
@chainyo chainyo linked an issue Sep 5, 2023 that may be closed by this pull request
Add auto dual-channel detection #238
Closed
@chainyo chainyo merged commit 0a95321 into main Sep 5, 2023
2 checks passed
@chainyo chainyo deleted the 238-add-auto-dual-channel-detection branch September 5, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandr-smechov aleksandr-smechov aleksandr-smechov approved these changes

Assignees
No one assigned
Labels
api Everything related to the API implementation audio Everything related to the audio pre or post-processing bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add auto dual-channel detection
2 participants
@chainyo @aleksandr-smechov