-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from poetry to hatch #227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainyo
added
documentation
Improvements or additions to documentation
api
Everything related to the API implementation
deploy
Everything related to Docker and deployment
labels
Sep 1, 2023
aleksandr-smechov
approved these changes
Sep 1, 2023
Yes, 0.5.0 |
I'm going to Bump the version too |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Everything related to the API implementation
deploy
Everything related to Docker and deployment
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a lot of stuff. It might be worth to prepare the
v0.5.0
release.Fixes #217
Fixes #226
alignment
(linked to WhisperX attribution #214)wordcab_transcribe
tosrc/wordcab_transcribe
ruff
andblack
-> Docker is for deployment only now. The base image is now super light (From 14GB to 4GB), and dependencies are downloaded at runtime when the app is launched.
Usage for Local development is in the README:
pipx install hatch
Run the app
hatch run runtime:launch # 🚀
Launch + youtube inference (outside docker example):
Quality & Tests
We still include a
pre-commit
hook if needed.