Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from poetry to hatch #227

Merged
merged 16 commits into from
Sep 1, 2023
Merged

Move from poetry to hatch #227

merged 16 commits into from
Sep 1, 2023

Conversation

chainyo
Copy link
Contributor

@chainyo chainyo commented Sep 1, 2023

This PR does a lot of stuff. It might be worth to prepare the v0.5.0 release.

Fixes #217
Fixes #226

  • Removed totally alignment (linked to WhisperX attribution #214)
  • Move files from wordcab_transcribe to src/wordcab_transcribe
  • Remove Poetry and Nox for Hatch
  • Simplify linter to ruff and black
  • Allow local usage without using Docker
    -> Docker is for deployment only now. The base image is now super light (From 14GB to 4GB), and dependencies are downloaded at runtime when the app is launched.

Usage for Local development is in the README:
pipx install hatch

Run the app

hatch run runtime:launch  # 🚀 

Launch + youtube inference (outside docker example):

CleanShot 2023-09-01 at 16 35 09@2x

Quality & Tests

# Quality checks without modifying the code
hatch run quality:check

# Quality checks and auto-formatting
hatch run quality:format

# Run tests with coverage
hatch run tests:run

We still include a pre-commit hook if needed.

pipx install pre-commit

pre-commit install

@chainyo chainyo added documentation Improvements or additions to documentation api Everything related to the API implementation deploy Everything related to Docker and deployment labels Sep 1, 2023
@chainyo chainyo linked an issue Sep 1, 2023 that may be closed by this pull request
@aleksandr-smechov
Copy link
Contributor

Yes, 0.5.0

@chainyo
Copy link
Contributor Author

chainyo commented Sep 1, 2023

Yes, 0.5.0

I'm going to Bump the version too

@chainyo chainyo merged commit 631e078 into main Sep 1, 2023
@chainyo chainyo deleted the 217-move-from-poetry-to-hatch branch September 1, 2023 14:52
@chainyo chainyo mentioned this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Everything related to the API implementation deploy Everything related to Docker and deployment documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erase alignment service Move from poetry to hatch
2 participants