Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement EncDecSpeakerLabelModel #202

Merged
merged 13 commits into from
Aug 31, 2023
Merged

Re-implement EncDecSpeakerLabelModel #202

merged 13 commits into from
Aug 31, 2023

Conversation

chainyo
Copy link
Contributor

@chainyo chainyo commented Aug 8, 2023 •
edited
Loading

This PR aims to re-implement the EncDecSpeakerModel used in the segmentation step of the diarization process.

  • Model cache dir paths
  • Model download if required
  • Untar the files
  • Load the config
  • Init nn.modules from config
    • Preprocessor
    • Encoder
    • Decoder
  • Forward function
  • Tests
  • Remove NeMo from dependencies
  • Update Docker image with recent CUDA and Python

@chainyo chainyo added the diarization Everything related to the diarization part label Aug 8, 2023
@chainyo chainyo self-assigned this Aug 8, 2023
@chainyo chainyo linked an issue Aug 8, 2023 that may be closed by this pull request
Implement the Segmentation model #196
Closed
@chainyo chainyo added the deploy Everything related to Docker and deployment label Aug 8, 2023
@chainyo chainyo marked this pull request as draft August 8, 2023 17:18
@aleksandr-smechov aleksandr-smechov marked this pull request as ready for review August 16, 2023 18:23
@chainyo
Copy link
Contributor Author

chainyo commented Aug 31, 2023

Update: I found the re-implementation problem and fixed it. Now I'm cleaning up the files and the dependencies, and I need to update the Docker image.

chainyo
chainyo commented Aug 31, 2023
View reviewed changes
Copy link
Contributor Author

@chainyo chainyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is good to go @aleksandr-smechov
Don't worry about failing CI, it will be updated by #217

@aleksandr-smechov aleksandr-smechov merged commit d303ac0 into main Aug 31, 2023
2 of 3 checks passed
@chainyo chainyo deleted the 196-implement-the-segmentation-model branch September 1, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandr-smechov aleksandr-smechov aleksandr-smechov approved these changes

Assignees

@chainyo chainyo

Labels
deploy Everything related to Docker and deployment diarization Everything related to the diarization part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the Segmentation model
2 participants
@chainyo @aleksandr-smechov