Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding vad_filter=True as a default fallback in case segments are empty #149

Merged
merged 2 commits into from
Jul 17, 2023
Merged

adding vad_filter=True as a default fallback in case segments are empty #149

merged 2 commits into from
Jul 17, 2023

Conversation

aleksandr-smechov
Copy link
Contributor

@aleksandr-smechov aleksandr-smechov commented Jul 16, 2023 •
edited
Loading

adding vad_filter=True as a default fallback in case segments are empty

@aleksandr-smechov aleksandr-smechov self-assigned this Jul 16, 2023
@aleksandr-smechov aleksandr-smechov linked an issue Jul 16, 2023 that may be closed by this pull request
Make internal_vad the default fallback for empty responses #147
Closed
@aleksandr-smechov aleksandr-smechov added bug Something isn't working transcription Everything related to the transcription part labels Jul 16, 2023
@aleksandr-smechov aleksandr-smechov changed the title adding internal_vad=True as a default fallback in case segments are empty adding vad_filter=True as a default fallback in case segments are empty Jul 16, 2023
@aleksandr-smechov
Copy link
Contributor Author

@chainyo confirming there's no error in outputs whether segments is an empty or non-empty list.

@chainyo chainyo merged commit 2dbb5da into main Jul 17, 2023
3 checks passed
@chainyo chainyo deleted the 147-internal-vad-default-fallback branch July 17, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chainyo chainyo chainyo approved these changes

Assignees

@aleksandr-smechov aleksandr-smechov

Labels
bug Something isn't working transcription Everything related to the transcription part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make internal_vad the default fallback for empty responses
2 participants
@aleksandr-smechov @chainyo