HTML API: Replace internal logic of force_balance_tags()
#7409
Conversation
The concept of `force_balance_tags()` is tricky at best. It's purpose, however is clear: clean up HTML input no matter how "bad" it appears. The HTML API introduces a new tool based on a systematic approach to normalizing by serializing. `WP_HTML_Processor::normalize()` produces clear and consistent output HTML regardless of the input and without any special-casing for "edge cases." As a spec-compliant parser, everything is a basic case of applying the parsing rules. Since there are still documents that the HTML API cannot parse, this is an optimistic refactor. For the cases of unsupported HTML, the behavior falls back to the legacy code. When the HTML API finished supporting all content it may be possible to eliminate the legacy code, but until then, most inputs will be handled by the HTML API.
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Resolved
Trac ticket: Core-55027 (February 2022)
Trac ticket: Core-44571 (July 2018)
Trac ticket: Core-40958 (June 2017)
Trac ticket: Core-39847 (February 2017)
Related
Trac ticket: Core-47514 (June 2019)
The concept of
force_balance_tags()is tricky at best. It's purpose, however is clear: clean up HTML input no matter how "bad" it appears.The HTML API introduces a new tool based on a systematic approach to normalizing by serializing.
WP_HTML_Processor::normalize()produces clear and consistent output HTML regardless of the input and without any special-casing for "edge cases." As a spec-compliant parser, everything is a basic case of applying the parsing rules.Since there are still documents that the HTML API cannot parse, this is an optimistic refactor. For the cases of unsupported HTML, the behavior falls back to the legacy code. When the HTML API finished supporting all content it may be possible to eliminate the legacy code, but until then, most inputs will be handled by the HTML API.