Interactivity Router: Pass translated strings via script module data #7304
+250
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This was referenced Sep 10, 2024
swissspidy
reviewed
Sep 11, 2024
| * @param array $data Data to filter. | ||
| * @return array Data for the Interactivity Router script module. | ||
| */ | ||
| public function filter_script_module_interactivity_router_data( array $data ): array { |
There was a problem hiding this comment.
Can't we find a better way?
This is really a step backwards from the JS I18N mechanism we implemented all those years ago 😞
Translators loose important context because the strings are no longer co-located with the code where they're being used. This also fails as soon as soon as you are dealing with plurals.
- Better modules - Parse wp modules from package.json - Combine asset file
This pulls the block-library assets from: WordPress/gutenberg@2632234
This reverts commit 404336b.
This script module requires an additional change that will be landed separately before it can be landed. See WordPress/gutenberg#65380.
…i18n-with-script-module-data
|
This is building on #7405. |
sirreal
added a commit
to WordPress/gutenberg
that referenced
this pull request
Sep 20, 2024
…i18n-with-script-module-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements script module data passing for translated strings matching the behavior in WordPress/gutenberg#65123.
Related PRs:
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.