Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL 8.4 LTS testing. #6680

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented May 30, 2024

MySQL 8.4 was released on April 30, 2024 and is the latest LTS version of MySQL.

This adds MySQL testing to the GitHub Actions and eliminates the MySQL innovation releases since they are no longer supported or receiving security releases.

In order to properly test and support MySQL 8.4 in the local Docker environment while still allowing PHP 7.2 and 7.3 to be used, some changes were required to dynamically determine which authentication plugin to use and any additional configuration that is required.

This means that instead of blanket enforcing mysql_native_password, the environment will now always use the default unless that's unsupported (like caching_sha2_password for PHP 7.2/7.3).

Trac ticket: https://core.trac.wordpress.org/ticket/61218


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this May 30, 2024
Copy link

github-actions bot commented May 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, jorbin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@aristath aristath self-requested a review July 31, 2024 10:59
docker-compose.old-php-mysql-84.override.yml Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
tools/local-env/scripts/install.js Outdated Show resolved Hide resolved
tools/local-env/scripts/utils.js Outdated Show resolved Hide resolved
desrosj and others added 4 commits August 6, 2024 12:40
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
@desrosj
Copy link
Contributor Author

desrosj commented Aug 6, 2024

@aristath I saw that you self assigned to perform a review. I think this is getting really close, so wanted to make sure you had a chance to take a look.

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @desrosj!

Added a comment 👍

.github/workflows/upgrade-testing.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants