-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise migration pointer un-dismissal to work for all admins #917
Revise migration pointer un-dismissal to work for all admins #917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Mostly looks great! A few points of feedback, most importantly regarding the query approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 The approach looks good to me now, there are only a few last quirks to iron out.
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@swissspidy @felixarntz PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukeshpanchal27, looks great!
@swissspidy Could you give this another look when you get a chance? |
8e377d5
into
feature/creating-standalone-plugins
Summary
Follow-up to #915 (comment)
Scenario that resolved by this PR:
That wouldn't be the case, maybe there was a misunderstanding or I didn't explain it well. The pointer wouldn't be dismissed for every user, it would only be "un-dismissed" for every user.
In other words:
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.