-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement admin pointer to indicate to the user they need to migrate modules to their standalone plugins #910
Implement admin pointer to indicate to the user they need to migrate modules to their standalone plugins #910
Conversation
…odule-migration-pointer
…odule-migration-pointer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukeshpanchal27. This looks good, though I left a few suggestions for improving the new function which is a bit too specifically tied to a UI consideration only relevant in one place.
Another thought on this (which if we go for it, we could implement in a separate PR): We may want to "un-dismiss" the migration pointer when the user activates a module? This would ensure that, if the user brings the site back into a "problematic" state after initially having fixed the problem, the pointer shows again. I think that would be helpful, especially if the logic here remains in the plugin indefinitely (see related #904 (comment)). We could just always remove the pointer from being dismissed whenever a module is activated, as the pointer would only actually show anyway if relevant for the site's current state. WDYT @mukeshpanchal27 @swissspidy? |
Yes. IMO we should do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukeshpanchal27, looks great!
Thanks @mukeshpanchal27. Can you open a follow up PR for this when you get a chance? Not a blocker for the release, but a nice to have enhancement. |
28b8905
into
feature/creating-standalone-plugins
Summary
Fixes #653
Prior to merging this PR, we'll need to ensure that #899 is merged.
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.