Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce viewport aspect ratio validation for URL Metrics #1494

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Introduce viewport aspect ratio validation for URL Metrics #1494

merged 7 commits into from
Aug 22, 2024

Commits on Aug 22, 2024

  1. Fix passing method name when failing to parse stored URL metric; incl… 

    …ude UUID when available
    @westonruter
    westonruter committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    285813d View commit details
    Browse the repository at this point in the history

  2. Introduce a required min/max viewport aspect ratio range

    @westonruter
    westonruter committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4cc2fb0 View commit details
    Browse the repository at this point in the history

  3. Handle OD_Data_Validation_Exception as rest_invalid_param error

    @westonruter
    westonruter committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f02365d View commit details
    Browse the repository at this point in the history

  4. Change a URL Metric validation error from a warning to a notice

    @westonruter
    westonruter committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    8299b06 View commit details
    Browse the repository at this point in the history

  5. Fix logic inversion in error message 

    Co-authored-by: Pascal Birchler <pascalb@google.com>
    @westonruter @swissspidy
    westonruter and swissspidy committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    672f2ab View commit details
    Browse the repository at this point in the history

  6. Improve phpdoc 

    Co-authored-by: Adam Silverstein <adamjs@google.com>
    @westonruter @adamsilverstein
    westonruter and adamsilverstein committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    df110d4 View commit details
    Browse the repository at this point in the history

  7. Consistently use default of 2:1 height and ensure integer

    @westonruter
    westonruter committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    161b201 View commit details
    Browse the repository at this point in the history