Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed: use 100% width for iframe. #995

Merged
merged 2 commits into from
Jun 2, 2017
Merged

Embed: use 100% width for iframe. #995

merged 2 commits into from
Jun 2, 2017

Conversation

mtias
Copy link
Member

@mtias mtias commented Jun 2, 2017

image

@mtias mtias added [Feature] Blocks Overall functionality of blocks Design labels Jun 2, 2017
@mtias mtias requested a review from jasmussen June 2, 2017 11:44
@jasmussen
Copy link
Contributor

Works well for me! 👍

@mtias
Copy link
Member Author

mtias commented Jun 2, 2017

Do you anticipate the generic width rule to have issues elsewhere?

@jasmussen
Copy link
Contributor

No, not width. Height, perhaps, but none that I can think of.

@mtias
Copy link
Member Author

mtias commented Jun 2, 2017

Ok, will merge.

@mtias mtias merged commit c1afcdb into master Jun 2, 2017
@mtias mtias deleted the update/show-WP-embed branch June 2, 2017 12:45
@aduth
Copy link
Member

aduth commented Jun 2, 2017

I think ResponsiveWrapper would serve well for embed iframes, since it can handle adjusting both height and width of the frame for smaller viewports if the natural dimensions are known:

https://github.com/WordPress/gutenberg/tree/master/components/responsive-wrapper

(Should write some docs 😄 )

@youknowriad
Copy link
Contributor

youknowriad commented Jun 2, 2017

@aduth should we use Storybook or write our own devdocs like calypso?

@aduth
Copy link
Member

aduth commented Jun 2, 2017

@youknowriad Would be interesting to explore, certainly. I think now that things have started to settle a bit more and documentation is clearly a pain point of past JavaScript in core, we have some good opportunities to showcase automated documentation. This is where I'm starting to go with #989, hoping to turn it into a function reference for eventual integration into the WordPress code reference. Something to what we did with Selectors DevDocs. We should probably reach out to the Documentation team to start coordinating too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants