Increase colour contrast on block mover buttons (#557) #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have checked the new contrast meets WCAG AA using the following tool: http://webaim.org/resources/contrastchecker/ If there’s a better checker you guys all use, do let me know in the comments!
aduth
added
[Focus] Accessibility (a11y)
|
This is what I see:
Nice, looks good, thanks for working on this! I did notice that the dark gray hover color doesn't actually work — it's replaced by a $medium-blue-500 color. Which frankly is probably better as it matches the hover color for similar buttons. So that hover rule can probably be removed. Otherwise 🚢 |
The button already inherits the hover colour from .components-icon-button.
|
Have removed the redundant hover. This might be my smallest PR ever, now ;) |
|
Not sure why travis failed on that one. But the change looks good now! |
|
I don't know if you fixed something @jasmussen but it seems to be passing here now. |
|
I guess the test ran again. Ship it! |
This was referenced Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have checked the new contrast meets WCAG AA using the following tool:
http://webaim.org/resources/contrastchecker/
If there’s a better checker you guys all use, do let me know in the comments!