Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter: let the content be taller #959

Closed
wants to merge 1 commit into from

Conversation

circlecube
Copy link
Contributor

The inserter window is too small on small screens especially. It was only fitting a couple rows. If a user clicks to insert we should give ample space so they can easily choose a block and get back to work, let's not get in their way.

The inserter window is too small on small screens especially.
@aduth
Copy link
Member

aduth commented May 31, 2017

Should this maybe be different between smaller and larger viewports, via breakpoint?

Else, maybe assign the vh with a static min-height value? (Demo)

cc @jasmussen

@circlecube
Copy link
Contributor Author

Good thought. I'm of the opinion that this inserter menu should always be as large as there is space for. Consider that when it's clicked, that is the function the user is focused on, so giving them a small window to a large menu just makes them work at picking the block they are looking for. If as much is visible as is possible, they will be faster to find their desired block and get back to editing their content. So whether we have breakpoints or not, I think the space should be bigger than it was (especially on smaller screens). Ideally a user has a large screen and sees the full menu, but sometimes that won't be the case and I don't think - especially on a small screen - hunting in a small viewport for an option is a good experience. A small view gets in the user's way more than anything.

@mtias
Copy link
Member

mtias commented May 31, 2017

This is an oversight on my part, it should have been vh from the start.

@aduth
Copy link
Member

aduth commented May 31, 2017

Ah, I forgot we hadn't revisited that. Yeah, at the very least we shouldn't e using the width unit. That might help to an extent.

@circlecube
Copy link
Contributor Author

Closing in favor of #978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants