Build: Fix components exports after refactor #957
Conversation
youknowriad
added
the
[Type] Bug
|
Yep. Sidebar is opening fine, things seem to be working! Thanks for fixing this so quick. No JS errors. 👍 |
| @@ -3,6 +3,8 @@ export { default as Dashicon } from './dashicon'; | |||
| export { default as FormToggle } from './form-toggle'; | |||
| export { default as IconButton } from './icon-button'; | |||
| export { default as Panel } from './panel'; | |||
| export { default as PanelHeader } from './panel/header'; | |||
| export { default as PanelBody } from './panel/body'; | |||
There was a problem hiding this comment.
Do we want to treat nested components the same as top-level? Wondering if either Panel.Body or import PanelBody from 'components/panel/header'; are better alternatives.
There was a problem hiding this comment.
The problem with import PanelBody from 'components/panel/header' is that it will cause the code to be duplicated across builds. This may be solvable via some trick I don't know about, see #941.
There was a problem hiding this comment.
Thanks for context @nylen . I'm finding I'm reading the sequence of these pull requests very much out of order 😛
|
Thanks for fixing this, and sorry for the breakage 😬 |
|
Is there still work to be done for #944 ? |
|
No, I think this is addressed via https://github.com/WordPress/gutenberg/pull/935/files#diff-512a8a050d031aaf7a1c47fb4f2a9656R10. |
Refactoring the components module build, broke some components. (Try opening the sidebar)
This should fix it
See #929 (comment)