Preserve isNew after save completes successfully #920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
|
Missed a spot: https://github.com/WordPress/gutenberg/pull/907/files#diff-aad59fa5eb910a7034e7a3cd9b491895L66 As far as the user experience, this controls the brief flash of text that appears when a save request is in progress. Prior to this PR it will say "Updating..." even for a new post; fixed in 2fec04e. |
nylen
approved these changes
May 27, 2017
|
As a separate task, I think the confusion here indicates that this part of the state tree should be restructured a bit. |
|
Thanks @nylen for noticing, explaining, and fixing 👍 Will merge shortly. |
|
My fault for being slow on revisiting my own pull requests. I'll plan to catch up with the activity there. |
|
Closing in favor of #945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #907 (comment)
This pull request resolves an issue where the
state.saving.isNewvalue is inaccurate after a post is saved successfully.Testing instructions:
Repeat instructions from #907 (comment)
Ensure unit tests pass: