Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort strikethrough after link #8755

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Conversation

jasmussen
Copy link
Contributor

This is a tiny PR to sort the "Strikethrough" button after the link.

One of the... perhaps this is unwritten and should be written down somewhere... one of the design principles of the block toolbar is that it starts with block related commands (like switcher), then block level (i.e. actions that apply to the whole block, like textalign applies for the whole paragraph), and finally inline level actions last. In the latter, it is sorted by presumed order of importance, and in this case, I would like to argue that Link is more important than Strikethrough.

One side effect of this is that one day when we can make the toolbar better handle nested contexts or small screens, we can "pop off" buttons into an overflow menu as the toolbar has to scale. If/when that happens, it's important that buttons are also sorted in order of importance.

screen shot 2018-08-09 at 09 19 53

This is a tiny PR to sort the "Strikethrough" button after the link.

One of the... perhaps this is unwritten and should be written down somewhere... one of the design principles of the block toolbar is that it starts with block related commands (like switcher), then _block level_ (i.e. actions that apply to the whole block, like textalign applies for the whole paragraph), and finally _inline level actions_ last. In the latter, it is sorted by presumed order of importance, and in this case, I would like to argue that Link is more important than Strikethrough.

One side effect of this is that one day when we can make the toolbar better handle nested contexts or small screens, we can "pop off" buttons into an overflow menu as the toolbar has to scale. If/when that happens, it's important that buttons are also sorted in order of importance.
@jasmussen jasmussen added the [Type] Enhancement A suggestion for improvement. label Aug 9, 2018
@jasmussen jasmussen self-assigned this Aug 9, 2018
@jasmussen jasmussen requested a review from a team August 9, 2018 07:23
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit 🚢

@jasmussen jasmussen added this to the 3.5 milestone Aug 9, 2018
@jasmussen jasmussen merged commit 0298cff into master Aug 9, 2018
@jasmussen jasmussen deleted the try/sort-strikethrough-last branch August 9, 2018 07:49
@mtias
Copy link
Member

mtias commented Aug 9, 2018

I agree, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants