Inserter: Try making the inline tokens less important #8587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
approved these changes
Aug 6, 2018
|
@jasmussen done :) |
|
Love it. The "longer term" fix might be as simple as simply having the inline elements panel be expanded from the start, when it's available! But for now, this is a great fix. Nice work! |
|
Good change, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback suggests that people are confused about the inline images. In most cases, they expect them to behave like the image blocks.
The ideal solution to this to show the inline tokens in the regular inserter category and not in a separate "Inline elements" panel but this requires more refactoring/thoughts. So I'm attempting a quick fix in this PR to move this "inline elements" panel down in the inserter.