Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote: add citation placeholder. #843

Merged
merged 2 commits into from
May 19, 2017
Merged

Conversation

mtias
Copy link
Member

@mtias mtias commented May 19, 2017

image

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. labels May 19, 2017
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small bug when we clear the citation input and focus the quote content area. The placeholder don't show up immediately, you have to unselece/select the block to make it appear.

This bug is not specific to this PR, but something that could appear with all placeholders.

👍 for this

@mtias
Copy link
Member Author

mtias commented May 19, 2017

I wonder if we should just do placeholders like this instead to simplify:

isEmptyContent && notFocused
    ? <span onClick={ setFocus }>Placeholder text</span>
    : <Editable />

cc @iseulde in case you already explored that.

@mtias mtias merged commit c769615 into master May 19, 2017
@mtias mtias deleted the add/quote-citation-placeholder branch May 19, 2017 15:12
@ellatrix
Copy link
Member

@youknowriad It looks like selectionChange does not fire then. @mtias I have not. I'n not sure how we'd handle tabbing etc. then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants