Dismiss block borders by key press #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onKeyDown emitted when modifier key, not the case with onKeyPress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #669
This pull request seeks to change the behavior of block border dismissal by typing to only dismiss borders when a key is pressed, excluding modifier keys (shift, etc.).
Implementation notes:
Technically this doesn't detect that input occurred, but rather that the key being pressed is not merely the first of a sequence of keys in a modifier combination.
Testing instructions:
Verify that block borders are dismissed when entering a character.
Verify that block borders are not dismissed when pressing shift.