Reapply box-sizing to slider thumbs. #8156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify the box-sizing in slider thumbs as Firefox does not inherit the box-sizing property on `-moz-range-thumb`.
jasmussen
approved these changes
Jul 30, 2018
There was a problem hiding this comment.
I can confirm this makes it look and behave the same in Firefox and Chrome. Chrome:
Firefox:
(Except for that focus style which Firefox adds, but that's fine).
And here's what's in master:
Ship it! 3.4 is on the press right now so milestoning this 3.5. Thanks for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specify the box-sizing in slider thumbs as Firefox does not inherit the box-sizing property on
-moz-range-thumb.How has this been tested?
Visually checked against Chrome implementation.
Screenshots
Firefox on the left, Chome on the right.
Note: disappearing slider is a gif artifact.
Types of changes
Bug fix for visual regression introduced PR #7545.
Checklist: