Block Movers: Hide movers if there are no blocks before and after. #8011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
force-pushed
the
fix/Hide-movers-if-there-are-no-blocks-before-and-after
branch
from
504742c
to
538da3d
Compare
jorgefilipecosta
changed the title
tofumatt
approved these changes
Aug 2, 2018
jorgefilipecosta
deleted the
fix/Hide-movers-if-there-are-no-blocks-before-and-after
branch
tofumatt
added a commit
that referenced
this pull request
Aug 2, 2018
|
Thank you for the review and for creating tests @tofumatt! |
tofumatt
added a commit
that referenced
this pull request
Aug 7, 2018
tofumatt
added a commit
that referenced
this pull request
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there are no blocks before or after the group of selected blocks, it is not possible to move the blocks anywhere.
In that case, we should not show the movers. Not showing the movers for this cases makes the UI cleaner in nested contexts as discovered in #7414.
How has this been tested?
I added Added a single paragraph and verified the movers did not appear.
I multi-selected some blocks without having non selected blocks before and after and verified the movers did not appear.
I repeated the tests for blocks inside a column.
I checked that when blocks could be moved the movers appear.