Additional keyboard shortcuts for the navigateRegions component #8005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
the
[Focus] Accessibility (a11y)
|
Confirm that |
afercia
force-pushed
the
update/navigate-regions-additional-shortcuts
branch
from
7fdc6b5
to
8b7fef0
Compare
|
Rebased to allow testing (the build was failing). |
4 tasks
afercia
force-pushed
the
update/navigate-regions-additional-shortcuts
branch
from
8b7fef0
to
d008ca6
Compare
|
Rebased. Let's see if the builds pass now. |
|
Would appreciate a quick review, thanks! 🙂 |
nerrad
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional keyboard shortcuts to navigate through the
navigateRegionssections. See the related issue #3218 where testing with different keyboard layouts proved the current shortcutCtrl+backtickis not usable with all keyboard layouts. At the very least, the backtick key is not available on the Italian, Dutch, Finnish, French, and likely more keyboard layouts.The additional shortcuts are:
shift+alt+nto go to the next regionshift+alt+pto go to the previous regionI've tested this on the following browsers:
and the new shortcuts seem to work without any conflict. Pending some more testing from the a11y team and anyone willing to test 🙂Some testing on a GNU-Linux distro would be nice.
If / when merged, I'd suggest to move #3218 to the accessibility Project instead of closing it, as the original idea of providing a mechanism to re-map and customize the keyboard shortcuts could be a nice improvement for the future.