Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a more recent revision/autosave exists, store its state on editor setup #7945

Merged
merged 22 commits into from
Apr 18, 2019
Merged

If a more recent revision/autosave exists, store its state on editor setup #7945

merged 22 commits into from
Apr 18, 2019

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Jul 13, 2018 •
edited
Loading

closes #7416

Attempts to resolve an issue whereby the editor is unaware of the existence of
a more recent autosave, resulting in attempts to perform an autosave fail.

Description

This PR results in autosave state being fetched when the editor loads (via a resolver). This request is preloaded (will require a core patch). Changes include:

  • Migration of autosave state from '@wordpress/editor' to '@wordpress/core-data'.
  • Addition of resolver for 'getAutosave' selector.
  • Disabling of the preview button until autosave state is fetched.
  • Deprecation of old selectors/actions

How has this been tested?

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Saving Related to saving functionality labels Jul 13, 2018
@talldan talldan self-assigned this Jul 13, 2018
@talldan talldan requested a review from aduth July 13, 2018 05:06
@talldan talldan mentioned this pull request Jul 13, 2018
Closed
aduth
aduth requested changes Jul 16, 2018
View reviewed changes
lib/client-assets.php Outdated Show resolved Hide resolved
@talldan talldan force-pushed the fix/initial-autosave-state branch from 73ed574 to 4c32e56 Compare July 20, 2018 06:15
@talldan

This comment has been minimized.

Sign in to view
@talldan talldan force-pushed the fix/initial-autosave-state branch 2 times, most recently from f5f49f9 to 27b921b Compare July 23, 2018 05:08
@youknowriad
Copy link
Contributor

This seems an important bug to fix, but I'm moving to 3.8 for now as it doesn't seem ready.

@talldan talldan force-pushed the fix/initial-autosave-state branch 2 times, most recently from 40cb6ab to 847c699 Compare September 4, 2018 08:38
@talldan talldan added the [Status] In Progress Tracking issues with work in progress label Sep 6, 2018
@talldan talldan force-pushed the fix/initial-autosave-state branch 2 times, most recently from 68791dd to 2af62da Compare September 7, 2018 14:21
@talldan

This comment has been minimized.

Sign in to view
@talldan

This comment has been minimized.

Sign in to view
@talldan talldan force-pushed the fix/initial-autosave-state branch 2 times, most recently from 53a19b0 to 9e1a31b Compare September 25, 2018 17:49
@talldan

This comment has been minimized.

Sign in to view
@talldan talldan mentioned this pull request Oct 10, 2018
Merged
@talldan talldan added Needs Technical Feedback Needs testing from a developer perspective. and removed [Status] In Progress Tracking issues with work in progress labels Oct 11, 2018
@aduth
Copy link
Member

aduth commented Nov 8, 2018

There's quite a bit which has since been changed in affected code here, for which I'm largely to blame (both for the changes and neglecting to review this sooner). Let me know if there's anything I can do to help with bringing this back up to date.

@talldan
Copy link
Contributor Author

talldan commented Nov 12, 2018

@aduth - I've rebased it. I ended up dropping a couple of commits that didn't seem relevant any more. They seem to have been fixed since.

My understanding is that if we want to introduce this, the PHP code will need to patched into core. Is that right?

@aduth
Copy link
Member

aduth commented Nov 12, 2018

Yes, and there may be some conflict to anticipate between this and the changes introduced to core as part of Trac#45194 (specifically 43833), which doesn't appear to have yet been ported back to the plugin (cc @imath @danielbachhuber).

@aduth aduth added the REST API Interaction Related to REST API label Nov 12, 2018
@danielbachhuber
Copy link
Member

the changes introduced to core as part of Trac#45194 (specifically 43833), which doesn't appear to have yet been ported back to the plugin

It's still a WIP on #4155

gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this pull request Sep 14, 2019
@jorgefilipecosta
Block Editor: Add preloading of autosaves.
a966d71 
With the introduction of WordPress/gutenberg#7945, the block editor requests autosave data when the editor is loaded. This can be optimized by preloading the request server-side and then passing the request data to the client using the preloading mechanism in editor-form-blocks.php.

Props: talldanwp, aduth.
Built from https://develop.svn.wordpress.org/trunk@46110


git-svn-id: https://core.svn.wordpress.org/trunk@45922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
miya0001 pushed a commit to cjk4wp/wordpress that referenced this pull request Oct 26, 2019
@jorgefilipecosta
Block Editor: Add preloading of autosaves.
9f75578 
With the introduction of WordPress/gutenberg#7945, the block editor requests autosave data when the editor is loaded. This can be optimized by preloading the request server-side and then passing the request data to the client using the preloading mechanism in editor-form-blocks.php.

Props: talldanwp, aduth.

git-svn-id: http://develop.svn.wordpress.org/trunk@46110 602fd350-edb4-49c9-b593-d223f7449a82
This was referenced Sep 11, 2024
Open
Open
Open
Open
Open
Open
Open
@AKJUS AKJUS mentioned this pull request Sep 12, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 12, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Open
Open
@AKJUS AKJUS mentioned this pull request Sep 14, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@AKJUS AKJUS mentioned this pull request Sep 19, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks noisysocks left review comments

@adamsilverstein adamsilverstein adamsilverstein left review comments

@aduth aduth aduth approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@gziolo gziolo Awaiting requested review from gziolo

@mkaz mkaz Awaiting requested review from mkaz

@nerrad nerrad Awaiting requested review from nerrad

@oandregal oandregal Awaiting requested review from oandregal

@notnownikki notnownikki Awaiting requested review from notnownikki

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@noisysocks noisysocks

@talldan talldan

Labels
[Feature] Saving Related to saving functionality REST API Interaction Related to REST API [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
5.6 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

Saving: Autosaveable does not account for autosave existing at start of editing
8 participants
@talldan @youknowriad @aduth @danielbachhuber @noisysocks @gziolo @adamsilverstein @nerrad