Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP attempt at making shared blocks behave like any ordinary CPT #7739

Closed
wants to merge 2 commits into from
Closed

WIP attempt at making shared blocks behave like any ordinary CPT #7739

wants to merge 2 commits into from

Conversation

noisysocks
Copy link
Member

@noisysocks noisysocks commented Jul 6, 2018 •
edited
Loading

Very rough exploration of some ideas for addressing #7387.

I took #7453 and changed a few things so that:

  • You can see shared blocks in wp-admin/edit.php?post_type=wp_block.
  • You can edit shared blocks in Gutenberg like regular posts.
  • You can switch shared blocks to draft to hide them from the frontend.
  • You can trash shared blocks to hide them from the frontend.

aduth and others added 2 commits June 21, 2018 15:54
@aduth
Blocks: Reimplement shared block as embedded editor
58c5103
@noisysocks
WIP attempt at making shared blocks behave like any ordinary CPT
c88dabc 
- You can see them in edit.php
- You can edit them via edit.php like regular Gutenberg posts
- You can switch them to draft to hide them from the frontend
- You can trash them to hide them from the frontend
@noisysocks noisysocks added the [Status] In Progress Tracking issues with work in progress label Jul 6, 2018
@aduth aduth force-pushed the update/shared-blocks-inner-editor branch from 58c5103 to 21d74e4 Compare July 12, 2018 20:33
@noisysocks noisysocks force-pushed the update/shared-blocks-inner-editor branch from 21d74e4 to fc7a096 Compare July 17, 2018 06:10
@noisysocks noisysocks force-pushed the update/shared-blocks-inner-editor branch 2 times, most recently from 9e7b7a3 to 061e9bd Compare August 22, 2018 05:17
@noisysocks noisysocks closed this Oct 17, 2018
@noisysocks noisysocks mentioned this pull request Oct 19, 2018
Closed
@noisysocks noisysocks deleted the add/shared-block-admin-ui-v2 branch November 6, 2018 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noisysocks @aduth