Packages: Move Plugins module to packages #7235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Code Quality
gziolo
force-pushed
the
update/move-plugins-packages
branch
from
d734512
to
089982b
Compare
gziolo
commented
Jun 8, 2018
| @@ -505,7 +505,7 @@ function gutenberg_register_scripts_and_styles() { | |||
| wp_register_script( | |||
| 'wp-plugins', | |||
| gutenberg_url( 'build/plugins/index.js' ), | |||
| array( 'wp-element', 'wp-components', 'wp-utils', 'wp-data' ), | |||
| array( 'lodash', 'wp-element', 'wp-hooks' ), | |||
There was a problem hiding this comment.
This is surprising! It was sort of broken but worked anyways ... :)
19 tasks
gziolo
force-pushed
the
update/move-plugins-packages
branch
from
cf62fc5
to
95a05d2
Compare
|
Thanks, rebased with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #3955.
How has this been tested?
The following commands should work:
npm testnpm run devnpm run buildCopy the following code into JS console: https://gist.github.com/gziolo/e2954aa83aa1f823b2b05ca1660c2223#file-my-plugin-es5-js. Make sure that sidebar plugins registers properly.
Checklist: