Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm v6 is the minimum required version #6629

Merged
merged 2 commits into from
May 9, 2018
Merged

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented May 7, 2018

Description

Updates the minimum required version of npm to version 6.0.0 or greater.

This is a follow up to #6610 (comment) where npm v6.0.0 was used to generate the package-lock.json file, everyone should be using the same version of npm otherwise there will be unnecessary and potentially troublesome pull requests submitted due to the differences in how npm v5 and v6 handle package-lock.json files.

How has this been tested?

Screenshots

Types of changes

Build tool update

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@ntwb ntwb added the [Type] Build Tooling Issues or PRs related to build tooling label May 7, 2018
@gziolo
Copy link
Member

gziolo commented May 8, 2018

I'm fine with the change, given that I'm already using v6.x locally :)
I think we have to update also docs if we want to introduce this change.

@gziolo gziolo requested a review from a team May 8, 2018 07:50
@gziolo gziolo added this to the 2.9 milestone May 8, 2018
@ntwb
Copy link
Member Author

ntwb commented May 8, 2018

Good call @gziolo, upon checking the docs already state to use the latest npm:

"You should also have the latest release of npm installed, npm is a separate project from Node.js and is updated frequently. If you've just installed Node.js which includes a version of npm within the installation you most likely will need to also update your npm install. To update npm, type this into your terminal: npm install npm@latest -g"

@gziolo
Copy link
Member

gziolo commented May 8, 2018

npm install npm@latest -g - should we use it with Travis, too? There is no @latest part.

@gziolo
Copy link
Member

gziolo commented May 8, 2018

Good docs, by the way. Future proof :)

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ntwb
Copy link
Member Author

ntwb commented May 8, 2018

npm install npm@latest -g - should we use it with Travis, too? There is no @latest part.

No, npm use @latest for new releases, for example 6.0.0 was released under latest for around two weeks before stable was bumped to 6.0.0, so let us avoid any bleeding edge releases and stick with stable

@pento pento merged commit 39b420f into master May 9, 2018
@pento pento deleted the update/npm-versions branch May 9, 2018 03:56
tofumatt added a commit that referenced this pull request May 9, 2018
Since #6629, npm 6 in the minimum version, so install it at setup time.
tofumatt added a commit that referenced this pull request May 9, 2018
Since #6629, npm 6 in the minimum version, so install it at setup time.
@drzraf
Copy link
Contributor

drzraf commented May 17, 2018

npm 6 is not even provided by https://github.com/nodesource/distributions (5.6 is)
That makes use of git code much harder...

After fixing packages.json to alow npm 5.6, npm run build gave me:

ERROR in ./edit-post/components/meta-boxes/meta-boxes-panel/style.scss
Module build failed: ModuleBuildError: Module build failed: Error: Node Sass does not yet support your current environment: Linux 64-bit with Unsupported runtime (64)
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.7.0
$ npm -v  
5.6.0
$ node -v
v10.1.0

which was solved by npm rebuild node-sass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants