Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the core/more block to ReactNative #6626

Merged
merged 16 commits into from
May 8, 2018
Merged

Port the core/more block to ReactNative #6626

merged 16 commits into from
May 8, 2018

Conversation

hypest
Copy link
Contributor

@hypest hypest commented May 7, 2018

Description

This PR ports the more block to the react-native app.

How has this been tested?

Types of changes

  • Introduces the edit.js module for the more block
  • Native RN version of the core-blocks/more/edit.js
  • Loads the more block styles from a scss file in this repo (editor.native.scss)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@hypest hypest added [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible Mobile Web Viewport sizes for mobile and tablet devices [Feature] Extensibility The ability to extend blocks or the editing experience labels May 7, 2018
@hypest hypest added this to the 2.9 milestone May 7, 2018
@hypest hypest requested a review from gziolo May 7, 2018 22:49
@hypest hypest changed the title Rnmobile/port more block updated Port the core/more block to ReactNative May 7, 2018
gziolo
gziolo approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and tests well. I'll open a follow up with all edit methods moved to their own files to make the explorations easier 👍

@gziolo gziolo merged commit f06a44f into master May 8, 2018
@gziolo gziolo deleted the rnmobile/port-more-block-updated branch May 8, 2018 09:01
This was referenced May 8, 2018
Merged
Merged
@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) and removed Mobile Web Viewport sizes for mobile and tablet devices labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.
3 participants
@hypest @gziolo @maxme