Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Makes edit mode selector persistent in top toolbar mode. #65511

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

vipul0425
Copy link
Contributor

What?

Fixes: #65508

Why?

Edit mode selector was not persistent when we switch to Top toolbar mode in site editor.

How?

This PR makes that button persistent even after toggling to Top toolbar mode.

Testing Instructions

  1. Open the site editor
  2. Click the pointer icon at the top left and toggle to the edit mode
  3. In the settings at the top right of the editor, switch to the top toolbar mode
  4. Notice that you can switch editing modes at the top left

Screenshots or screencast

Screen.Recording.2024-09-20.at.12.05.40.PM.mov

Copy link

github-actions bot commented Sep 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vipul0425 <vipulgupta003@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@amitraj2203 amitraj2203 added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Sep 20, 2024
@youknowriad youknowriad added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Sep 20, 2024
@youknowriad
Copy link
Contributor

I'm guessing the original thinking is that we wanted to gain space in top toolbar mode to leave enough place for the block toolbar. I think this PR is fine personally. So just want to confirm that it's ok for designers too.

@jameskoster
Copy link
Contributor

It seems necessary to me. I don't see a good reason that activating Top toolbar should prohibit you from switching modes.

@youknowriad youknowriad merged commit 8e79558 into WordPress:trunk Sep 20, 2024
69 of 72 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContentOnly Select Mode: In Top Toolbar mode, it is not possible to toggle between Design and Edit modes
4 participants