Select Mode: Updates to the block toolbar #65485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
commented
Sep 19, 2024
| if ( isEmpty ) { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the only change to this file, the isEmpty flag was added and the dropdown is not rendered if empty.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Sep 19, 2024
| @@ -35,36 +35,40 @@ function BlockSwitcherDropdownMenuContents( { | |||
| clientIds, | |||
| hasBlockStyles, | |||
| canRemove, | |||
| isUsingBindings, | |||
There was a problem hiding this comment.
No need to pass this prop from up to down, it's better to collocate the call.
youknowriad
commented
Sep 19, 2024
| @@ -196,7 +200,7 @@ const BlockIndicator = ( { icon, showTitle, blockTitle } ) => ( | |||
| </> | |||
| ); | |||
|
|
|||
| export const BlockSwitcher = ( { clientIds, disabled, isUsingBindings } ) => { | |||
There was a problem hiding this comment.
Collocated both of these props.
youknowriad
commented
Sep 19, 2024
| ( isDefaultEditingMode || | ||
| ( isContentOnlyEditingMode && ! hasParentPattern ) || | ||
| isSynced ) && ( | ||
| ! hasParentPattern && ( |
|
Size Change: +58 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Love this! Feeling much more like an editing experience centred around page building using patterns. |
9 tasks
|
Yeah this feels like a step forward 💪 Some observations:
inserter.mp4 |
youknowriad
requested review from
ajitbohra,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
youknowriad
force-pushed
the
update/block-toolbar-edit-mode
branch
from
973b495
to
fad0d9e
Compare
|
Flaky tests detected in b941814. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10958244637
|
I'm most likely not understanding this point, for me there's no inconsistency, can you clarify? |
Both of these are things we can explore. I want to focus on the minimal changes to the toolbar for the current PR (just reuse what we have already).
I will look into it. It might be a bit hard to know whether there's a tool or not though 😬 (given all the extensibility APIs)
Yep, I can reproduce, I'll look into it but that feels separate from the current PR though, we should add it to the todo list in the issue to track it/fix it. |
Yes, so it's actually very hard to "detect" when a toolbar is empty or not. My best guess at the moment would be to actually do some CSS hack with Given that we want to explore adding names and potentially shuffle buttons, I was wondering whether the current state could be an acceptable tradeoff for this PR. |
youknowriad
force-pushed
the
update/block-toolbar-edit-mode
branch
from
fad0d9e
to
b941814
Compare
|
@jameskoster The bug about the in between inserter showing up is being fixed separately here #65529 |
Sure, see the video below: template.mp4
Edit: I noticed the section does appear in list view if you move it: group.mp4
Probably okay, though for this PR it would be good to fix the appearance of a 'double border' on the right-hand side of the toolbar: 
One other question; is it intentional that I cannot select the title or featured image when editing a page in edit mode? |
I can't reproduce the issue, for me it works. I'm suspecting there's a bug in the way some of the selectors are memoized. Causing different results depending on what you did before.
Well, these are not "content" blocks, so yeah, it is just the algorithm of "contentOnly" basically. |
|
The double border issue is fixed. Note that if you notice an editor crash (some kind of infinite loop) when testing this PR, it's mostly likely due to this unrelated PR #65494 (ignore that error for now) |
I suppose it should be discussed separately but I feel like there may be a nuance there. I suspect folks would expect the title to be editable regardless of mode. |
|
Ok, I found the bug where sometimes the list of blocks in list view is not refreshed properly. It exists in trunk too but I included the fix here in the last commit (it's a small one) ac423e4 |
youknowriad
force-pushed
the
update/block-toolbar-edit-mode
branch
from
ac423e4
to
b5476d9
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #65204
This PR makes some changes to the block toolbar behavior for "sections" (content-only containers, select mode, reusable blocks...) and simplifies things a little bit.
Here's the list of changes that I made so far:
Testing instructions