-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEWP: Handle cyclical module dependencies #65291
Merged
+112
−5
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
edb8889
Add tests for cyclical dependencies
michalczaplinski 67d0676
Add the externals and make the test fail
michalczaplinski 8fd700f
Add cycle detection in dependency path checking
michalczaplinski 5654813
Revert changes
sirreal b19c3e0
Propose static WeakSet/WeakMap implementation.
sirreal 3f8f2f4
Add CHANGELOG entry
sirreal b5e33db
Remove redundant plugin config in test
sirreal 44d6968
Revert "Remove redundant plugin config in test"
sirreal 0c2de0d
Remove redundant plugin config in test
sirreal 81d15af
Updated the snapshot files
michalczaplinski 8a0eabb
Merge remote-tracking branch 'origin/trunk' into fix/dewp-cyclical-deps
michalczaplinski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
packages/dependency-extraction-webpack-plugin/test/fixtures/cyclic-deps/a.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/** | ||
* Internal dependencies | ||
*/ | ||
import { someFunction } from '.'; | ||
|
||
someFunction(); | ||
|
||
export const a = 'test'; |
8 changes: 8 additions & 0 deletions
8
packages/dependency-extraction-webpack-plugin/test/fixtures/cyclic-deps/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/** | ||
* Internal dependencies | ||
*/ | ||
import { a } from './a'; | ||
|
||
export const someFunction = () => { | ||
return a; | ||
}; |
8 changes: 8 additions & 0 deletions
8
packages/dependency-extraction-webpack-plugin/test/fixtures/cyclic-deps/webpack.config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
/** | ||
* Internal dependencies | ||
*/ | ||
const DependencyExtractionWebpackPlugin = require( '../../..' ); | ||
|
||
module.exports = { | ||
plugins: [ new DependencyExtractionWebpackPlugin() ], | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there will need to be an external module listed here that's used in one or both of the file and we can probably disable defaults as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jon! Yeah, I've added it now!
I think I didn't realize this before: The problem that I found only affects the externalized modules. Do you think that's correct?