Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigator: add support for exit animation #64777

Open
wants to merge 34 commits into
base: trunk
Choose a base branch
from
Open

Navigator: add support for exit animation #64777

wants to merge 34 commits into from
+366 −97

Commits on Sep 20, 2024

  1. Refactor screen logic for better clarity and hook deps

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4a15a9f View commit details
    Browse the repository at this point in the history

  2. Add exit animation, rewrite screen animations / DOM rendering logic

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b71b9ca View commit details
    Browse the repository at this point in the history

  3. Only add inset CSS rule when animating out

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    531e5d7 View commit details
    Browse the repository at this point in the history

  4. Parametrise animation

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    95b5915 View commit details
    Browse the repository at this point in the history

  5. CHANGELOG

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ada9d3c View commit details
    Browse the repository at this point in the history

  6. Add fallback timeout

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a7a1b0d View commit details
    Browse the repository at this point in the history

  7. Mention wrapper height in README

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9ab8436 View commit details
    Browse the repository at this point in the history

  8. Use useReducedMotion() hook instead of custom logic

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a95a321 View commit details
    Browse the repository at this point in the history

  9. Extract useScreenAnimatePresence hook, tidy up

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    57a1dc0 View commit details
    Browse the repository at this point in the history

  10. Forward animationEnd

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b2c00a5 View commit details
    Browse the repository at this point in the history

  11. Add setWrapperHeight functionality via context

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    aa3581b View commit details
    Browse the repository at this point in the history

  12. Use clip instead of hidden for overflow-x

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7979797 View commit details
    Browse the repository at this point in the history

  13. Less aggressive clipping for screens that are animating out

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    91bd4c8 View commit details
    Browse the repository at this point in the history

  14. Better sizing styles for screen, to keep it more stable while transit… 

    …ioning out
    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a34d20b View commit details
    Browse the repository at this point in the history

  15. Refine internal animation logic for less jumpy animations

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0c31d57 View commit details
    Browse the repository at this point in the history

  16. Remove unnecessary Storybook styles

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    718a481 View commit details
    Browse the repository at this point in the history

  17. Change wording

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    06c80fd View commit details
    Browse the repository at this point in the history

  18. Improve logic: 

    - more clear animation status names
- apply CSS animation only while effectively animating
- fix bug in the animationEnd callback which was matching animation end
  events too loosely, thus causing glitches
    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e6b7fe4 View commit details
    Browse the repository at this point in the history

  19. Add timeout fallback for in animations too

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6982b31 View commit details
    Browse the repository at this point in the history

  20. Fix animation delay for forwards.out animation

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2c3b07c View commit details
    Browse the repository at this point in the history

  21. Use display: grid instead of absolute positioning to set provider min… 

    … height

Remove unnecessary import
    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    248a02d View commit details
    Browse the repository at this point in the history

  22. Simplify navigatorScreenAnimation

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9b2882b View commit details
    Browse the repository at this point in the history

  23. Fix initial goTo

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    be908c2 View commit details
    Browse the repository at this point in the history

  24. Remove unnecessary state element ref

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0ca9991 View commit details
    Browse the repository at this point in the history

  25. Use "start" and "end" instead of "backwards" and "forwards"

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6156fbb View commit details
    Browse the repository at this point in the history

  26. Do not rely on usePrevious

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f8dc99f View commit details
    Browse the repository at this point in the history

  27. Use CSS transitions

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    da023c7 View commit details
    Browse the repository at this point in the history

  28. Fix Storybook example

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    581604d View commit details
    Browse the repository at this point in the history

  29. Rework global styles layout, so that each screen scrolls its own content

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1e349d2 View commit details
    Browse the repository at this point in the history

  30. Revert "Use CSS transitions" 

    This reverts commit 946f9c953232b788f58050d2a94d9d131527a180.
    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    76f9d07 View commit details
    Browse the repository at this point in the history

  31. Switch to data-attributes for less runtime emotion calculations

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    22220a0 View commit details
    Browse the repository at this point in the history

  32. Add back fallback animation timeout

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    389a953 View commit details
    Browse the repository at this point in the history

  33. Move CHANGELOG entry to unreleased section

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    094336a View commit details
    Browse the repository at this point in the history

  34. Clean up code, reduce diff for easier reviewing

    @ciampo
    ciampo committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    59cc407 View commit details
    Browse the repository at this point in the history