Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tools: Fix the package plugin script #6463

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Conversation

youknowriad
Copy link
Contributor

I'm not certain this is the correct fix but there's already another polyfilled function add_action so to fix the package plugin script, I added a polyfill the newly used function wp_add_inline_script.

There's probably a better way to write this script but it would probably require fetching WordPress Core while the current script is independent.

Testing instructions

  • run npm run package-plugin
  • It should produce a correct gutenberg zip.

@youknowriad youknowriad added the [Type] Build Tooling Issues or PRs related to build tooling label Apr 27, 2018
@youknowriad youknowriad added this to the 2.8 milestone Apr 27, 2018
@youknowriad youknowriad self-assigned this Apr 27, 2018
@youknowriad youknowriad requested a review from a team April 27, 2018 08:37
@gziolo
Copy link
Member

gziolo commented Apr 27, 2018

FILE: /app/bin/get-vendor-scripts.php

FOUND 1 ERROR AFFECTING 1 LINE

18 | ERROR | Missing function doc comment
| | (Squiz.Commenting.FunctionComment.Missing)

I guess, this requires another function comment to make phpcs happy... 😄

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested locally and it worked fine.

It needs a small tweak to satisfy phpcs and is good to go :shipit:

@youknowriad youknowriad merged commit 01388cb into master Apr 27, 2018
@youknowriad youknowriad deleted the fix/package-plugin branch April 27, 2018 09:46
@mcsf
Copy link
Contributor

mcsf commented Apr 27, 2018

I had this fix on my git stash and forgot to make it a PR, d'oh! 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants