Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite v2: undo stabilizing new version #64510

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Aug 14, 2024

What?

Remove Composite from the @wordpress/components package exports

Why?

After recently exposing the component, we realised that there some aspects of its public APIs that we'd like to re-discuss ane make sure we get right before committing to them.

Removing the component from the package's public APIs shouldn't be an issue, since those changes never got released.

How?

Testing Instructions

@ciampo ciampo requested a review from ajitbohra as a code owner August 14, 2024 14:54
@ciampo ciampo requested a review from a team August 14, 2024 14:54
@ciampo ciampo self-assigned this Aug 14, 2024
Copy link

github-actions bot commented Aug 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ciampo ciampo added [Package] Components /packages/components [Type] Iteration Scoped iteration of an effort from a tracking issue or overview issue ideally for a major release. labels Aug 14, 2024
@ciampo ciampo modified the milestone: Gutenberg 19.1 Aug 14, 2024
@ciampo ciampo added [Type] Experimental Experimental feature or API. and removed [Type] Iteration Scoped iteration of an effort from a tracking issue or overview issue ideally for a major release. labels Aug 14, 2024
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Hoping we can revert this soon 😅

@ciampo ciampo enabled auto-merge (squash) August 14, 2024 15:15
@ciampo ciampo merged commit 93b4738 into trunk Aug 14, 2024
69 of 75 checks passed
@ciampo ciampo deleted the feat/stabilize-composite/halt branch August 14, 2024 15:29
@github-actions github-actions bot added this to the Gutenberg 19.1 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants