Block Editor: Remove CSS hack for Internet Explorer 11 #63220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -42 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jul 8, 2024
|
@jasmussen Thanks for the review!
I think it's enough to just make sure that the block toolbar is displayed in the correct layout as before 👍 |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #58034
This PR is the final one to remove fallback styles for IE11 for stylesheets.
What?
Remove the CSS code for IE11 that exists in the
block-editorpackage. The styles that will be removed are all related to the block toolbar.Why?
Support for IE11 has been officially removed in WordPress 5.8. And since the Gutenberg plugin no longer supports WordPress 5.8, we can remove the fallback code for IE11.
Testing Instructions
The layout of the block toolbar should remain the same.