Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Appearance Control: Refactor font appearance fallbacks #63215

Merged
merged 28 commits into from
Jul 15, 2024
Merged

Font Appearance Control: Refactor font appearance fallbacks #63215

merged 28 commits into from
Jul 15, 2024

Commits on Jul 6, 2024

  1. Refactor font appearance fallbacks

    @mikachan
    mikachan committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    68dc225 View commit details
    Browse the repository at this point in the history

  2. Create new findNearestStyleAndWeight function

    @mikachan
    mikachan committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3b434b1 View commit details
    Browse the repository at this point in the history

  3. Add tests for findNearestStyleAndWeight

    @mikachan
    mikachan committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    dacc850 View commit details
    Browse the repository at this point in the history

  4. Refactor findNearestStyleAndWeight

    @mikachan
    mikachan committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    23a8fa2 View commit details
    Browse the repository at this point in the history

  5. Add a test for normal/100

    @mikachan
    mikachan committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    2e0e9c5 View commit details
    Browse the repository at this point in the history

  6. Add comments

    @mikachan
    mikachan committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    5a22028 View commit details
    Browse the repository at this point in the history

  7. Tidy up comments

    @mikachan
    mikachan committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    9813347 View commit details
    Browse the repository at this point in the history

  8. Fix test description

    @mikachan
    mikachan committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    23567d5 View commit details
    Browse the repository at this point in the history

  9. Update test descriptions

    @mikachan
    mikachan committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    1f102c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Update deps and wrap setFontAppearance and resetFontAppearance in use… 

    …Callback
    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c74daeb View commit details
    Browse the repository at this point in the history

  2. Add e2e test for appearance control dropdown menu

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    7e027b4 View commit details
    Browse the repository at this point in the history

  3. Add periods to end of comments

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ef7350b View commit details
    Browse the repository at this point in the history

  4. Use better test data for font appearance e2e default test

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a796d13 View commit details
    Browse the repository at this point in the history

  5. Add findNearestFontStyle function with tests

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    72199cc View commit details
    Browse the repository at this point in the history

  6. Limit the dependency array to just fontFamily

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3796305 View commit details
    Browse the repository at this point in the history

  7. Add normal font style test

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    64b13cc View commit details
    Browse the repository at this point in the history

  8. Add invalid font style test

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    fc209a6 View commit details
    Browse the repository at this point in the history

  9. Try toHaveText instead of toContainText

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1f69824 View commit details
    Browse the repository at this point in the history

  10. Try using TT4 for e2e test rather than TT3

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a7a3b6a View commit details
    Browse the repository at this point in the history

  11. Merge branch 'trunk' into try/refactor-font-appearance-defaults

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    74edc0c View commit details
    Browse the repository at this point in the history

  12. Use combobox role rather than button in e2e test

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    cec7d9d View commit details
    Browse the repository at this point in the history

  13. Merge branch 'trunk' into try/refactor-font-appearance-defaults

    @mikachan
    mikachan committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    08e73d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Merge branch 'trunk' into try/refactor-font-appearance-defaults

    @mikachan
    mikachan committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2e23bc5 View commit details
    Browse the repository at this point in the history

  2. Set nearestFontStyle to an empty string by default

    @mikachan
    mikachan committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b06c4e4 View commit details
    Browse the repository at this point in the history

  3. Refactor findNearestFontStyle

    @mikachan
    mikachan committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b407be1 View commit details
    Browse the repository at this point in the history

  4. Do not activate a theme in font appearance e2e test

    @mikachan
    mikachan committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    9d7dfc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Run findNearestStyleAndWeight only when fontFamily has changed

    @mikachan
    mikachan committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    18e1bfe View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Only trigger appearance onChange if values are different

    @mikachan
    mikachan committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    8288dd4 View commit details
    Browse the repository at this point in the history