Font Library Modal: enhance pagination appearance #63210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +1.11 kB (+0.06%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
This feels like an improvement, so 👍 👍. Though for the pagination on the list view work going on, pagination is still evolving, with some changes around next/previous pages, the dropdown for selecting a specific page, etc. I wonder if it would be worth it to turn that whole piece into a single Pagination component, so we don't have to maintain several different styles of this? |
This is certainly worthwhile. I suggested this in #55650, but I'm still not sure what UI works best and covers all use cases. |
|
I think @jameskoster may have worked on some bits recently. |
|
For data views it has been suggested not to include first/last icon buttons. They add noise, consume space (problematic on mobile), and when there are enough pages to make use of them (quite rare) it's generally easier to use the dedicated page selection UI. Another suggestion has been to use the double-arrow for next/previous, to reduce overlap between these buttons and other chevrons. This is the design: 
But it's blocked by #57720 |
When I created this PR, I wondered whether to apply this approach to the font library modal as well. On the other hand, the Revisions panel has First Page and Last Page buttons:
In addition, there are a huge number of Google fonts, so some users may want to go back to the first page with one click. Also, the first page and last page buttons were originally in the font library modal. I'm wondering to what extent these UIs should be unified 😅 |
|
I thought about the first and last page buttons too, in the name of the huge amount of pages. However it's not clear to me that those are hugely valuable when you have this many pages, arguably improved search would be better. There use of the double chevron resonates since we really have many triangle chevrons in the UI already. Not a strong opinion. |
|
I removed the first page/last page buttons.
But the icons are not double chevrons because all paginations use single chevrons for previous/next buttons. Is it ok to change it to double chevrons in this PR? Or should we unify everything to double chevrons, including other paginations, in a follow-up PR? |
Seems fine to me, yes. Regardless, there's work to be done across pagination, even for list views. |
jasmussen
approved these changes
Jul 9, 2024
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
* Font Library Modal: enhance pagination appearance * Remove first/last page buttons Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59408
Part of #60528
What?
This PR improves the appearance of pagination in the Font Library modal, making it more consistent with the pagination UI in the Data View and Revisions panel.
How?
Testing Instructions
In the font library, make sure pagination still works as before.
Screenshots or screencast
Before
After