-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BaseControl: forward ref on VisualLabel #63169
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 11b1c81. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9804807507
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward change, LGTM 👍
* BaseControl: forward ref on VisualLabel * Remove unnecessary @ts-expect-error * CHANGELOG
What?
Extracted from #63137
Allow ref forwarding on
BaseControl.VisualLabel
Why?
For better composition with other components.
How?
Wrapped
BaseControl.VisualLabel
in aReact.forwardRef
Testing Instructions
Smoke test Storybook and the editor, make sure everything looks and behaves as normal