Remove third party domain #63154
Merged
Remove third party domain #63154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwilsoncc
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
peterwilsoncc
added
the
[Type] Copy
|
Size Change: +118 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
peterwilsoncc
commented
Jul 4, 2024
| { sprintf( | ||
| /* translators: %1$s The home URL of the WordPress installation without the scheme. */ | ||
| __( | ||
| "Child pages inherit characteristics from their parent, such as URL structure. For instance, if 'Web Design' is a child of 'Services,' its URL would be %1$s/services/web-design." |
There was a problem hiding this comment.
What's correct in American English: 'Services,' or 'Services',?
There was a problem hiding this comment.
Normally American English puts punctuation inside speech quotes as far as I know.
However, in this example, we're citing a UI label. There's no comma in the label - adding one would change its meaning.
I think it's therefore acceptable to use 'Services',.
ramonjd
approved these changes
Jul 5, 2024
docs/how-to-guides/metabox.md
Outdated
| @@ -243,7 +243,7 @@ When the meta box area is saving, we display an updating overlay, to prevent use | |||
|
|
|||
| An example save url would look like: | |||
|
|
|||
| `mysite.com/wp-admin/post.php?post=1&action=edit&meta-box-loader=1` | |||
| `example.com/wp-admin/post.php?post=1&action=edit&meta-box-loader=1` | |||
There was a problem hiding this comment.
Very weakly-held opinion - would example.org reflect more the non-profit nature of the WordPress org?
Comment on lines
220
to
225
| const { homeUrl } = useSelect( ( select ) => { | ||
| const { getUnstableBase } = select( coreStore ); | ||
| return { | ||
| homeUrl: getUnstableBase()?.home, | ||
| }; | ||
| }, [] ); |
There was a problem hiding this comment.
Adding the current site host is a nice touch.
The only reservation I'd have is for sites with very long domain names. It could push out the UI. In that case something like example.com|org could be safer? What do you reckon?
100% optional.
Suggested change
| const { homeUrl } = useSelect( ( select ) => { | |
| const { getUnstableBase } = select( coreStore ); | |
| return { | |
| homeUrl: getUnstableBase()?.home, | |
| }; | |
| }, [] ); | |
| const { homeUrl } = useSelect( ( select ) => ( { | |
| homeUrl: select( coreStore ).getUnstableBase()?.home | |
| } ), [] ); |
There was a problem hiding this comment.
Yeah, I'm not sure what is better and most clear for the end user: accuracy or brevity.
For wordpress.com sub-domains it can be quite long, the same will be true for the various make.wordpress.org blogs.
| 
| 
|
There was a problem hiding this comment.
Maybe just use example.com|org?
Less code, 0.00001 faster (no useSelect) and folks can always do a follow up.
There was a problem hiding this comment.
Cool, I've pushed that. I'll give others the chance to weigh in before merging.
|
Flaky tests detected in fa7b407. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9801636224
|
peterwilsoncc
added
the
Backport to WP 6.6 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 5, 2024
Removes references to a third party domain outside of the WordPress project's control with the reserved domain example.org. For the inline documentation a translator note is added alerting the polyglots to use either a reserved domain or a wordpress.org domain/sub-domain. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 590f24c |
|
@ellatrix was this change included in today's package release for WP 6.6 RC3 package update? |
|
(Commented in Slack, yes) |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
…63154). Removes references to a third party domain outside of the WordPress project's control with the reserved domain example.org. For the inline documentation a translator note is added alerting the polyglots to use either a reserved domain or a wordpress.org domain/sub-domain. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces references to
mysite.comwithexample.comFixes https://core.trac.wordpress.org/ticket/61570
Why?
This comes out of discussion in the polyglots slack channel to avoid references to potentially live third party sites.
As WordPress has no control over the sites, this could be problematic if the content of the demonstration URL was either malware or content unsuitable for people of all ages.
How?
mysite.comis replaced withexample.orgInitially I used the homeURL of the site but @ramonjd and I were worried it could become too long for the copy space so we went with the reserved domain instead. If needs be, it can be switched to home URL later.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast