-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove third party domain #63154
Remove third party domain #63154
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +118 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
{ sprintf( | ||
/* translators: %1$s The home URL of the WordPress installation without the scheme. */ | ||
__( | ||
"Child pages inherit characteristics from their parent, such as URL structure. For instance, if 'Web Design' is a child of 'Services,' its URL would be %1$s/services/web-design." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's correct in American English: 'Services,'
or 'Services',
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally American English puts punctuation inside speech quotes as far as I know.
However, in this example, we're citing a UI label. There's no comma in the label - adding one would change its meaning.
I think it's therefore acceptable to use 'Services',
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/how-to-guides/metabox.md
Outdated
@@ -243,7 +243,7 @@ When the meta box area is saving, we display an updating overlay, to prevent use | |||
|
|||
An example save url would look like: | |||
|
|||
`mysite.com/wp-admin/post.php?post=1&action=edit&meta-box-loader=1` | |||
`example.com/wp-admin/post.php?post=1&action=edit&meta-box-loader=1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very weakly-held opinion - would example.org
reflect more the non-profit nature of the WordPress org?
const { homeUrl } = useSelect( ( select ) => { | ||
const { getUnstableBase } = select( coreStore ); | ||
return { | ||
homeUrl: getUnstableBase()?.home, | ||
}; | ||
}, [] ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the current site host is a nice touch.
The only reservation I'd have is for sites with very long domain names. It could push out the UI. In that case something like example.com|org
could be safer? What do you reckon?
100% optional.
const { homeUrl } = useSelect( ( select ) => { | |
const { getUnstableBase } = select( coreStore ); | |
return { | |
homeUrl: getUnstableBase()?.home, | |
}; | |
}, [] ); | |
const { homeUrl } = useSelect( ( select ) => ( { | |
homeUrl: select( coreStore ).getUnstableBase()?.home | |
} ), [] ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just use example.com|org
?
Less code, 0.00001
faster (no useSelect
) and folks can always do a follow up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I've pushed that. I'll give others the chance to weigh in before merging.
Flaky tests detected in fa7b407. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9801636224
|
Removes references to a third party domain outside of the WordPress project's control with the reserved domain example.org. For the inline documentation a translator note is added alerting the polyglots to use either a reserved domain or a wordpress.org domain/sub-domain. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: 590f24c |
@ellatrix was this change included in today's package release for WP 6.6 RC3 package update? |
(Commented in Slack, yes) |
…63154). Removes references to a third party domain outside of the WordPress project's control with the reserved domain example.org. For the inline documentation a translator note is added alerting the polyglots to use either a reserved domain or a wordpress.org domain/sub-domain. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
What?
Replaces references to
mysite.com
withexample.com
Fixes https://core.trac.wordpress.org/ticket/61570
Why?
This comes out of discussion in the polyglots slack channel to avoid references to potentially live third party sites.
As WordPress has no control over the sites, this could be problematic if the content of the demonstration URL was either malware or content unsuitable for people of all ages.
How?
mysite.com
is replaced withexample.org
Initially I used the homeURL of the site but @ramonjd and I were worried it could become too long for the copy space so we went with the reserved domain instead. If needs be, it can be switched to home URL later.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast