ProgressBar: Fix indeterminate RTL support #63129
Conversation
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -67,7 +76,7 @@ export const Indicator = styled.div< { | |||
| animationDuration: '1.5s', | |||
| animationTimingFunction: 'ease-in-out', | |||
| animationIterationCount: 'infinite', | |||
| animationName: animateProgressBar, | |||
| animationName: animateProgressBar( isRTL() ), | |||
There was a problem hiding this comment.
I don't think I've ever thought of using the isRTL() check directly in the styled components, I always used it in the render function and passed it as a prop. Interesting!
There was a problem hiding this comment.
It felt simpler to me, rather than having to introduce yet another prop. I'm happy to consider changing it if you feel it can be improved.
* ProgressBar: Fix indeterminate RTL support * CHANGELOG Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
What?
Fix the RTL support for the indeterminate
ProgressBarcomponent.Why?
Currently on RTL, the indeterminate progress bar animates from left to right.
How?
By parametrizing the animation by direction and taking it into account.
Testing Instructions
ProgressBarcomponent in storybookvalueand verify determinate mode also works well in LTR and RTL.Testing Instructions for Keyboard
None
Screenshots or screencast
Before:
Screen.Recording.2024-07-04.at.16.31.29.mov
After:
Screen.Recording.2024-07-04.at.16.29.55.mov