-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post editor: Fix triple scrollbars in device previews #62940
Conversation
Size Change: +7 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
Flaky tests detected in 780284a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9701280175
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also made another small PR that only shows the second device preview scrollbar when really needed - #62952 |
* Fix triple scrollbars in post editor * Restore flex of VisualEditor when metaboxes are present Co-authored-by: stokesman <presstoke@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: ec9720d |
I came across this PR while investigating the issue reported in #63110. This PR may have caused two issues for the post editor that is not iframed and does not have meta boxes.
"The post editor that is not iframed and does not have meta boxes" refers to when a block version 3 or below is registered without custom fields enabled. In this case, the For more information on this issue, see #63110. |
What?
Fixes #62911
A fix for a regression in the Post editor where device previews create three scrolling areas.
Why?
In WP 6.5 device previews in the Post editor don’t have three scrolling areas.
How?
Revises a selector to more selectively apply some styles that cause the issue. The styles appear to only be helpful when metaboxes are present.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After
More about the issue
As best I can tell this came about from introducing the "Zoom out" experiment. While that is still an experiment it did introduce markup and style changes that are present even when not opting into the experiment. Testing WP nightly in playground I can reproduce the issue:
![image](https://private-user-images.githubusercontent.com/9000376/343948285-a4afa0a6-31d2-401a-9afb-8694cbde5ba9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxMTI5OTQsIm5iZiI6MTcyNDExMjY5NCwicGF0aCI6Ii85MDAwMzc2LzM0Mzk0ODI4NS1hNGFmYTBhNi0zMWQyLTQwMWEtOWFmYi04Njk0Y2JkZTViYTkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjBUMDAxMTM0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2NkN2VkMWE4MzBiMDljODU3MWYxMWZhMDViN2NkOGU5ODlmYTc1NGU1NzU2MDdhMzZhOTBkZDk2MWY2NmRmMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.cXDmebxT2HXAu_EuJiheINYvoe3AXSB44PlKYBdplds)