-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align rename modals #62874
Align rename modals #62874
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: -24 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Nice work. The only one I don't agree with is the notice change, this one:
I can see sense in using the basic "Name" label for the input field, but I'd keep the help text below, and keep it as plain body text. The consequences are important to understand, but it doesn't need further elevation since you're already in a modal context. This is also mostly about that particular notice style being generally out of place in the block editor, it doesn't share any DNA with the snackbar, for instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submitted a commit to fix the e2e tests.
Regarding the notice message, I also feel it's a bit too noticeable.
Good feedback, I'll change the notice 👍 How do y'all feel about these questions?
|
Flaky tests detected in 7dedd28. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9698824225
|
No strong opinion.
Save read well to me. It's active language just like Rename, but benefits from the reduced duplication, while still being the action taken. |
I think accessibility feedback is needed on this. I remember that @afercia submitted some issues on this point to improve the consistency/accessibility of modals/dialogs. He might have some advice. |
Generally, visible labels are always better especially with complex forms with several input fields. Re: the buttons text, I provided some previous feedback but that was specifically about the |
These inconsistencies will need to be fixed in the future. Considering avoiding the "OK" label and avoiding duplicate labels, my options for this PR are "Save", "Update", and "Apply". Of these, I prefer "Save", which means we'll ship this PR as is. |
Eheh yes that's a good case. I'd love to see some established guidelines added to the documentation of these components. Maybe it is worth creating a follow-up issue?. For reference, regarding the |
I'm going to flip-flop on this and lean towards repetition 🙊 for two main reasons:
I could be swayed back again, but I'm curious... if not "Duplicate", what would the primary button label be in the In any case, it's a broader topic, so I'm happy to ship this PR as is, and discuss the labels further in a separate issue/pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, it's a broader topic, so I'm happy to ship this PR as is, and discuss the labels further in a separate issue/pr.
I agree with this. This PR only includes one button text change, and by unifying everything to "Save", we have improved consistency.
I think the other issues can be addressed by following up.
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
Follow-up to #62788.
The vast majority of rename modals appear in the following format:
This PR brings a couple of outliers into alignment with this convention.
Navigation menus
Note the visible label.
Renaming blocks
Renaming custom views
Testing Instructions
Additional alignment considerations