Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern overrides: Fix aspect ratio not working in image with overrides #62828

Merged
merged 10 commits into from
Jun 27, 2024
Merged

Pattern overrides: Fix aspect ratio not working in image with overrides #62828

merged 10 commits into from
Jun 27, 2024

Commits on Jun 25, 2024

  1. Remove only supported attributes

    @SantosGuillamot
    SantosGuillamot committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    94fd308 View commit details
    Browse the repository at this point in the history

  2. Try alternative approach

    @SantosGuillamot
    SantosGuillamot committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    61eb825 View commit details
    Browse the repository at this point in the history

  3. Update comment

    @SantosGuillamot
    SantosGuillamot committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1980e79 View commit details
    Browse the repository at this point in the history

  4. Return early while editing the original pattern

    @SantosGuillamot
    SantosGuillamot committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    fff77d4 View commit details
    Browse the repository at this point in the history

  5. Move conditional inside conditional

    @SantosGuillamot
    SantosGuillamot committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4faa8bb View commit details
    Browse the repository at this point in the history

  6. Add missing check

    @SantosGuillamot
    SantosGuillamot committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    46d01ad View commit details
    Browse the repository at this point in the history

  7. Go back to running always bindings

    @SantosGuillamot
    SantosGuillamot committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e1bdd7e View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Use block context to detect presence of parent pattern for overrides (#… 

    …62861)

* Use block context to detect presence of parent pattern

* Regenerate fixtures

* Update image block to use context for checking a parent pattern block exists

* Rename context to `pattern/overrides` to be consistent with php code

* Move pattern overrides context shim to pattern overrides hooks

* Remove shim

Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
    @talldan @ellatrix @SantosGuillamot
    4 people committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    9ee6ad3 View commit details
    Browse the repository at this point in the history

  2. Reduce diff

    @SantosGuillamot
    SantosGuillamot committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7ed761a View commit details
    Browse the repository at this point in the history

  3. Change array order

    @SantosGuillamot
    SantosGuillamot committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    47f554e View commit details
    Browse the repository at this point in the history