Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fix blocked Post Publish Panel buttons on mobile #62736

Conversation

ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Jun 21, 2024

What?

Fixes #62738.

There's a small regression introduced by #62237 where on mobile viewport, the Publish and Cancel buttons are not visible.

Before After
Markup on 2024-06-21 at 12:43:44 Markup on 2024-06-21 at 12:45:00

Why?

Without the fix, the Publish and Cancel buttons are not visible.

How?

By setting .editor-post-publish-panel's top property to $admin-bar-height-big - as it used to be

Testing Instructions

  1. Switch to mobile view.
  2. Start creating a new post.
  3. Add some content and click the Publish button.
  4. The Publish and Cancel buttons should be visible.

Testing Instructions for Keyboard

N/A

Screenshots or screencast

Shared above.

Copy link

github-actions bot commented Jun 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jun 21, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ivan-ottinger! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@youknowriad
Copy link
Contributor

When testing this, I noticed another issue.

The Document Bar is visible on mobile and If I'm not wrong, it's supposed to be removed from mobile viewports and I'm not sure what PR restored it.

Screenshot 2024-06-21 at 3 06 45 PM

Anyway it's not a blocker for this PR.

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jun 21, 2024
@youknowriad youknowriad merged commit 26b7a12 into WordPress:trunk Jun 21, 2024
64 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.7 milestone Jun 21, 2024
@youknowriad
Copy link
Contributor

Side thought: we definitely lack e2e tests on mobile, we should probably consider writing some of these to avoid similar regressions in the future.

ellatrix pushed a commit that referenced this pull request Jun 25, 2024
#62736)

Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
@ellatrix
Copy link
Member

I just cherry-picked this PR to the wp/6.6-rc-1 branch to get it included in the next release: 49cfe51

@ellatrix ellatrix added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jun 25, 2024
ellatrix pushed a commit that referenced this pull request Jun 25, 2024
#62736)

Co-authored-by: ivan-ottinger <ivanottinger@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
@ivan-ottinger
Copy link
Contributor Author

included in the next release: 49cfe51

Thank you, Ella.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Post Publish Panel buttons not visible on mobile
3 participants