Fix regression with columns appender #6237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the default appender in columns would have a border, and the wrong font. This was introduced as part of the input style consistency PR. Increasing selector specificity fixes this.
|
@jasmussen I can't find the changes where the I've created this plugin : http://wordpress.org/plugins/block-options/ and the options I've added are not showing on the inner columns anymore. Thanks! |
|
Cool plugin! I don't know that I'm the right one to ask (at least I don't know how to answer). If you can, can you ask your question in the WordPress core editor chat? https://make.wordpress.org/chat/ — channel: #core-editor — you can ping me, username @joen in slack, and I'll boost your signal. |
|
Thanks @jasmussen :) Really appreciated! |
4 tasks
nuzzio
pushed a commit
to nuzzio/gutenberg
that referenced
this pull request
Apr 25, 2018
This fixes an issue where the default appender in columns would have a border, and the wrong font. This was introduced as part of the input style consistency PR. Increasing selector specificity fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the default appender in columns would have a border, and the wrong font. This was introduced as part of the input style consistency PR. Increasing selector specificity fixes this.
Before:
After:
👋 don't mind the yellow background color, I'm experimenting with editor styles :D