Privatize an experimental prop for inserter menu #62110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +754 B (+0.04%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
…omponent directly
|
It's unclear here what is going on. In the 1st commit I import from the private apis of the block editor package but that somehow builds fine but crashes the private imports in the browser. In the second commit it works, but alas actually it's not InserterMenu but InserterLibrary that should be privatised. Because it is InserterLibrary which is used outside of the block editor package, not InserterMenu which introduces the prop, so the public API comes from InserterLibrary ... But InserterLibrary is already exported as __experimental so ... does that mean anything? Should I drop __experimental now that I make a private version? Do I keep a public experimental component which is different from the private one? |
|
Closed in favor of #62130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast