Fix editor inserter tabs indicator #61973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DaniGuardiola
added
[Type] Bug
tyxla
approved these changes
May 28, 2024
There was a problem hiding this comment.
This fixes it for me 👍 Thanks. 🚀
Can you please rebase to the latest trunk before merging?
Also, I'd appreciate some more structured details in the PR (what/why/how) and testing instructions in the future. Following the default template is generally good practice and can help contributors orient themselves in the details of each change.
…ix/editor-inserted-tabs-indicator
|
Size Change: +4 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f876fd5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9270714451
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #60560 (comment)
#60560 introduced a minor layout change in the Tabs component that broke the inserter tabs indicator (hacky CSS overrides at it again :P). This PR fixes this.
Before:
After:
chrome_DItpzeDWwt.mp4
Specifically, the tabs indicator needs to overlap the lower border. The layout changes in #60560 made the negative margin that achieved this not work anymore. This PR fixes it to overlap again, as can be seen in the before and after images.